Accessibility improvements: add text for empty links and buttons and alt text for images#7635
Open
labkey-susanh wants to merge 4 commits intodevelopfrom
Open
Accessibility improvements: add text for empty links and buttons and alt text for images#7635labkey-susanh wants to merge 4 commits intodevelopfrom
labkey-susanh wants to merge 4 commits intodevelopfrom
Conversation
cnathe
requested changes
May 1, 2026
| <% } | ||
| if (null != me.getViewContext().getContainer()) { | ||
| %><a href="<%=h(me.getPermaLink())%>" id="permalink" name="permalink" style="display: none;"></a><% | ||
| %><a href="<%=h(me.getPermaLink())%>" id="permalink" name="permalink" style="display: none;"><span class="sr-only">Page link<span></span></span></a><% |
Contributor
There was a problem hiding this comment.
is the extra <span></span> needed here?
Contributor
Author
There was a problem hiding this comment.
No, certainly not. Some sort of auto-completion "help" at play here.
cnathe
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
For better accessibility, we need to provide text for links and buttons that are only icons and alt text for images.
Related Pull Requests
Changes